lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)
From
On 9/27/22 03:58, David Laight wrote:
> From: Sean Anderson
>> Sent: 24 September 2022 02:54
>>
>> With the power of variadic macros, double parentheses are unnecessary.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> Changes in v2:
>> - sumhme -> sunhme
>>
>> drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
>> 1 file changed, 136 insertions(+), 136 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
>> index 7d6825c573a2..77a2a192f2ce 100644
>> --- a/drivers/net/ethernet/sun/sunhme.c
>> +++ b/drivers/net/ethernet/sun/sunhme.c
>> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
>> #endif
>>
>> #ifdef HMEDEBUG
>> -#define HMD(x) printk x
>> +#define HMD printk
>
> That probably ought to be:
> #define HMD(...) printk(__VA_ARGS__)
>
> (and followed through all the other patches)

The final macro is

#define hme_debug(fmt, ...) pr_debug("%s: " fmt, __func__, ##__VA_ARGS__)
#define HMD hme_debug

so I think that satisfies your comment.

--Sean

\
 
 \ /
  Last update: 2022-09-27 15:58    [W:0.559 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site