lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)
Date
From: Sean Anderson
> Sent: 24 September 2022 02:54
>
> With the power of variadic macros, double parentheses are unnecessary.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>
> Changes in v2:
> - sumhme -> sunhme
>
> drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
> 1 file changed, 136 insertions(+), 136 deletions(-)
>
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 7d6825c573a2..77a2a192f2ce 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
> #endif
>
> #ifdef HMEDEBUG
> -#define HMD(x) printk x
> +#define HMD printk

That probably ought to be:
#define HMD(...) printk(__VA_ARGS__)

(and followed through all the other patches)

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

\
 
 \ /
  Last update: 2022-09-27 10:05    [W:0.069 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site