lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 6/7] remoteproc: qcom: Add efuse evb selection control
From

On 9/23/2022 10:55 PM, Krzysztof Kozlowski wrote:
Thanks for Your time Krzyszto!!!
> On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote:
>> Add efuse evb selection control and enable it for starting ADSP.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
> Thank you for your patch. There is something to discuss/improve.
>
>> @@ -543,6 +549,17 @@ static int adsp_init_mmio(struct qcom_adsp *adsp,
>> return PTR_ERR(adsp->qdsp6ss_base);
>> }
>>
>> + efuse_region = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> + if (!efuse_region) {
>> + adsp->lpass_efuse = NULL;
>> + dev_dbg(adsp->dev, "failed to get efuse memory region\n");
>> + } else {
> This needs bindings updates in all users.

Actually this is being used in SC7280 platform only. I am not sure if it
applicable for other platforms.

If required, it can be posted as new series after this series got main
lined.

>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2022-09-27 15:36    [W:0.044 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site