Messages in this thread | | | Date | Fri, 23 Sep 2022 19:25:38 +0200 | Subject | Re: [PATCH v8 6/7] remoteproc: qcom: Add efuse evb selection control | From | Krzysztof Kozlowski <> |
| |
On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote: > Add efuse evb selection control and enable it for starting ADSP. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com> > ---
Thank you for your patch. There is something to discuss/improve.
> @@ -543,6 +549,17 @@ static int adsp_init_mmio(struct qcom_adsp *adsp, > return PTR_ERR(adsp->qdsp6ss_base); > } > > + efuse_region = platform_get_resource(pdev, IORESOURCE_MEM, 1); > + if (!efuse_region) { > + adsp->lpass_efuse = NULL; > + dev_dbg(adsp->dev, "failed to get efuse memory region\n"); > + } else {
This needs bindings updates in all users.
Best regards, Krzysztof
| |