Messages in this thread | | | Date | Tue, 27 Sep 2022 13:36:37 +0200 | From | Nam Cao <> | Subject | Re: [RFC PATCH 2/5] staging: vt6655: change vnt_receive_frame return type to void |
| |
On Mon, Sep 19, 2022 at 12:45:11PM +0300, Dan Carpenter wrote: > On Thu, Sep 15, 2022 at 10:29:33PM +0200, Nam Cao wrote: > > -bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd) > > +void vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd) > > { > > struct vnt_rd_info *rd_info = curr_rd->rd_info; > > struct sk_buff *skb; > > @@ -133,13 +133,13 @@ bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd) > > /* Frame Size error drop this packet.*/ > > dev_dbg(&priv->pcid->dev, "Wrong frame size %d\n", frame_size); > > dev_kfree_skb_irq(skb); > > - return true; > > + return; > > } > > > > if (vnt_rx_data(priv, skb, frame_size)) > > - return true; > > + return; > > > > dev_kfree_skb_irq(skb); > > > > - return true; > > + return; > > Just delete this last return (it's pointless now).
Will be changed, thanks.
Best regards, Nam
| |