lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/5] staging: vt6655: change vnt_receive_frame return type to void
On Thu, Sep 15, 2022 at 10:29:33PM +0200, Nam Cao wrote:
> -bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
> +void vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
> {
> struct vnt_rd_info *rd_info = curr_rd->rd_info;
> struct sk_buff *skb;
> @@ -133,13 +133,13 @@ bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
> /* Frame Size error drop this packet.*/
> dev_dbg(&priv->pcid->dev, "Wrong frame size %d\n", frame_size);
> dev_kfree_skb_irq(skb);
> - return true;
> + return;
> }
>
> if (vnt_rx_data(priv, skb, frame_size))
> - return true;
> + return;
>
> dev_kfree_skb_irq(skb);
>
> - return true;
> + return;

Just delete this last return (it's pointless now).

> }

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-09-19 11:47    [W:0.643 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site