Messages in this thread | | | Date | Tue, 27 Sep 2022 11:31:22 +0900 | Subject | Re: [PATCH v3 7/8] scsi: libsas: use sas_phy_addr_match() instead of open coded | From | Damien Le Moal <> |
| |
On 9/27/22 11:29, Jason Yan wrote: > The sas address comparation of expander phys is open coded. Now we can > replace it with sas_phy_addr_match().
s/comparation/comparison
All the other patches have the same typo too.
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
With that fixed,
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> --- > drivers/scsi/libsas/sas_expander.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c > index b2b5103c3e76..f268291b7584 100644 > --- a/drivers/scsi/libsas/sas_expander.c > +++ b/drivers/scsi/libsas/sas_expander.c > @@ -2058,8 +2058,7 @@ static int sas_rediscover(struct domain_device *dev, const int phy_id) > > if (i == phy_id) > continue; > - if (SAS_ADDR(phy->attached_sas_addr) == > - SAS_ADDR(changed_phy->attached_sas_addr)) { > + if (sas_phy_addr_match(phy, changed_phy)) { > last = false; > break; > }
-- Damien Le Moal Western Digital Research
| |