lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 3/8] scsi: pm8001: use sas_find_attached_phy() instead of open coded
    Date
    The attached phy finding is open coded. Now we can replace it with
    sas_find_attached_phy().

    Signed-off-by: Jason Yan <yanaijie@huawei.com>
    Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
    ---
    drivers/scsi/pm8001/pm8001_sas.c | 16 +++++-----------
    1 file changed, 5 insertions(+), 11 deletions(-)

    diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
    index 8e3f2f9ddaac..d15a824bcea6 100644
    --- a/drivers/scsi/pm8001/pm8001_sas.c
    +++ b/drivers/scsi/pm8001/pm8001_sas.c
    @@ -645,22 +645,16 @@ static int pm8001_dev_found_notify(struct domain_device *dev)
    pm8001_device->dcompletion = &completion;
    if (parent_dev && dev_is_expander(parent_dev->dev_type)) {
    int phy_id;
    - struct ex_phy *phy;
    - for (phy_id = 0; phy_id < parent_dev->ex_dev.num_phys;
    - phy_id++) {
    - phy = &parent_dev->ex_dev.ex_phy[phy_id];
    - if (SAS_ADDR(phy->attached_sas_addr)
    - == SAS_ADDR(dev->sas_addr)) {
    - pm8001_device->attached_phy = phy_id;
    - break;
    - }
    - }
    - if (phy_id == parent_dev->ex_dev.num_phys) {
    +
    + phy_id = sas_find_attached_phy(&parent_dev->ex_dev, dev);
    + if (phy_id == -ENODEV) {
    pm8001_dbg(pm8001_ha, FAIL,
    "Error: no attached dev:%016llx at ex:%016llx.\n",
    SAS_ADDR(dev->sas_addr),
    SAS_ADDR(parent_dev->sas_addr));
    res = -1;
    + } else {
    + pm8001_device->attached_phy = phy_id;
    }
    } else {
    if (dev->dev_type == SAS_SATA_DEV) {
    --
    2.31.1
    \
     
     \ /
      Last update: 2022-09-27 04:20    [W:3.489 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site