Messages in this thread | | | Date | Mon, 26 Sep 2022 10:58:18 +0300 | From | Mathias Nyman <> | Subject | Re: [PATCH] xhci: print warning when HCE was set |
| |
On 24.9.2022 5.35, liulongfang wrote: > On 2022/9/22 21:01, Mathias Nyman Wrote: >> Hi >> >> On 15.9.2022 4.11, Longfang Liu wrote: >>> When HCE(Host Controller Error) is set, it means that the xhci hardware >>> controller has an error at this time, but the current xhci driver >>> software does not log this event. >>> >>> By adding an HCE event detection in the xhci interrupt processing >>> interface, a warning log is output to the system, which is convenient >>> for system device status tracking. >>> >> >> xHC should cease all activity when it sets HCE, and is probably not >> generating interrupts anymore. >> >> Would probably be more useful to check for HCE at timeouts than in the >> interrupt handler. >> > > Which function of the driver code is this timeout in?
xhci_handle_command_timeout() will usually trigger at some point,
> >> If this is something seen on actual hardware then it makes sense to add it. >> > > This HCE error is sure to report an interrupt on the chip we are using.
Ok, then makes sense to add this patch.
Thanks -Mathias
| |