Messages in this thread | | | Date | Fri, 2 Sep 2022 11:49:54 +0200 | From | Andrew Jones <> | Subject | Re: [PATCH 2/4] riscv: drop some idefs from CMO initialization |
| |
On Fri, Sep 02, 2022 at 12:27:42AM +0200, Heiko Stuebner wrote: > Wrapping things in #ifdefs makes the code harder to read > while we also have IS_ENABLED() macros to do this in regular code > and the extension detection is not _that_ runtime critical. > > So define a stub for riscv_noncoherent_supported() in the > non-CONFIG_RISCV_DMA_NONCOHERENT case and move the code to > us IS_ENABLED. > > Suggested-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/riscv/errata/thead/errata.c | 7 +++---- > arch/riscv/include/asm/cacheflush.h | 2 ++ > arch/riscv/kernel/cpufeature.c | 22 +++++++++------------- > 3 files changed, 14 insertions(+), 17 deletions(-) >
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
| |