lkml.org 
[lkml]   [2022]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full()
On Fri, Sep 2, 2022 at 12:18 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Sep 2, 2022 at 11:10 AM John Garry <john.garry@huawei.com> wrote:
> >
> > The code to create the child platform device is essentially the same as
> > what platform_device_register_full() does, so change over to use
> > that same function to reduce duplication.
>
> Now statistics plays for you and not against.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Too fast to give a tag, see below (keep tag if addressing it)

...

> > - pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);
> > + pdev = platform_device_register_full(cell->pdevinfo);

> > if (!pdev)
> > return -ENOMEM;

As per kernel doc:
* Returns &struct platform_device pointer on success, or ERR_PTR() on error.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-09-02 11:24    [W:0.438 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site