Messages in this thread | | | Date | Fri, 2 Sep 2022 10:35:45 +0100 | Subject | Re: [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full() | From | John Garry <> |
| |
On 02/09/2022 10:21, Andy Shevchenko wrote: >> Reviewed-by: Andy Shevchenko<andy.shevchenko@gmail.com> > Too fast to give a tag, see below (keep tag if addressing it)
thanks
> > ... > >>> - pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO); >>> + pdev = platform_device_register_full(cell->pdevinfo); >>> if (!pdev) >>> return -ENOMEM; > As per kernel doc: > * Returns &struct platform_device pointer on success, or ERR_PTR() on error.
ah, right, I thought that I got that correct....
John
| |