Messages in this thread Patch in this message | | | Date | Mon, 19 Sep 2022 13:25:50 -0000 | From | "tip-bot2 for Sebastian Andrzej Siewior" <> | Subject | [tip: irq/core] platform/x86: intel_int0002_vgpio: Use generic_handle_irq_safe() |
| |
The following commit has been merged into the irq/core branch of tip:
Commit-ID: c6a91405ac5cd5baa03fea061e11b05788223160 Gitweb: https://git.kernel.org/tip/c6a91405ac5cd5baa03fea061e11b05788223160 Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de> AuthorDate: Mon, 19 Sep 2022 14:44:28 +02:00 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Mon, 19 Sep 2022 15:08:38 +02:00
platform/x86: intel_int0002_vgpio: Use generic_handle_irq_safe()
On PREEMPT_RT enabled kernels the demultiplex interrupt handler is force threaded and runs with interrupts enabled. The invocation of generic_handle_irq() with interrupts enabled triggers a lockdep warning due to a non-irq safe lock acquisition.
Instead of disabling interrupts on the driver level, use generic_handle_domain_irq_safe().
[ tglx: Split out from combo patch ]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/YnkfWFzvusFFktSt@linutronix.de --- drivers/platform/x86/intel/int0002_vgpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/x86/intel/int0002_vgpio.c index 617dbf9..97cfbc5 100644 --- a/drivers/platform/x86/intel/int0002_vgpio.c +++ b/drivers/platform/x86/intel/int0002_vgpio.c @@ -125,8 +125,7 @@ static irqreturn_t int0002_irq(int irq, void *data) if (!(gpe_sts_reg & GPE0A_PME_B0_STS_BIT)) return IRQ_NONE; - generic_handle_irq(irq_find_mapping(chip->irq.domain, - GPE0A_PME_B0_VIRT_GPIO_PIN)); + generic_handle_domain_irq_safe(chip->irq.domain, GPE0A_PME_B0_VIRT_GPIO_PIN); pm_wakeup_hard_event(chip->parent);
| |