lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: irq/core] gpio: mlxbf2: Use generic_handle_irq_safe()
    The following commit has been merged into the irq/core branch of tip:

    Commit-ID: 118c3ba24d04f084eadd9d4a0ab7830f495e9106
    Gitweb: https://git.kernel.org/tip/118c3ba24d04f084eadd9d4a0ab7830f495e9106
    Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    AuthorDate: Mon, 19 Sep 2022 14:45:18 +02:00
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitterDate: Mon, 19 Sep 2022 15:08:38 +02:00

    gpio: mlxbf2: Use generic_handle_irq_safe()

    On PREEMPT_RT enabled kernels the demultiplex interrupt handler is force
    threaded and runs with interrupts enabled. The invocation of
    generic_handle_irq() with interrupts enabled triggers a lockdep warning due
    to a non-irq safe lock acquisition.

    Instead of disabling interrupts on the driver level, use
    generic_handle_domain_irq_safe().

    [ tglx: Split out from combo patch ]

    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/YnkfWFzvusFFktSt@linutronix.de
    ---
    drivers/gpio/gpio-mlxbf2.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
    index 64cb060..77a4115 100644
    --- a/drivers/gpio/gpio-mlxbf2.c
    +++ b/drivers/gpio/gpio-mlxbf2.c
    @@ -273,10 +273,8 @@ static irqreturn_t mlxbf2_gpio_irq_handler(int irq, void *ptr)
    pending = readl(gs->gpio_io + YU_GPIO_CAUSE_OR_CAUSE_EVTEN0);
    writel(pending, gs->gpio_io + YU_GPIO_CAUSE_OR_CLRCAUSE);

    - for_each_set_bit(level, &pending, gc->ngpio) {
    - int gpio_irq = irq_find_mapping(gc->irq.domain, level);
    - generic_handle_irq(gpio_irq);
    - }
    + for_each_set_bit(level, &pending, gc->ngpio)
    + generic_handle_domain_irq_safe(gc->irq.domain, level);

    return IRQ_RETVAL(pending);
    }
    \
     
     \ /
      Last update: 2022-09-19 15:26    [W:2.236 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site