Messages in this thread | | | Date | Mon, 19 Sep 2022 12:15:43 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH net-next v2 4/5] net: mediatek: sgmii: set the speed according to the phy interface in AN |
| |
On Mon, Sep 19, 2022 at 10:37:11AM +0200, Alexander Couzens wrote: > The non auto-negotioting code path is setting the correct speed for the > interface. Ensure auto-negotiation code path is doing it as well.
While I see the logic in doing this in the autoneg path, if you look at mtk_pcs_config(), you'll notice that this code you're adding is unreachable.
If interface is PHY_INTERFACE_MODE_2500BASEX, then we will call mtk_pcs_setup_mode_force(). We only call mtk_pcs_setup_mode_an() for the PHY_INTERFACE_MODE_SGMII case when in-band mode is selected, so this can become:
regmap_read(mpcs->regmap, mpcs->ana_rgc3, &val); val &= ~RG_PHY_SPEED_MASK; regmap_write(mpcs->regmap, mpcs->ana_rgc3, val);
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |