lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 3/5] net: mediatek: sgmii: mtk_pcs_setup_mode_an: don't rely on register defaults
On Mon, Sep 19, 2022 at 10:37:10AM +0200, Alexander Couzens wrote:
> Ensure autonegotiation is enabled.
>
> Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
> ---
> drivers/net/ethernet/mediatek/mtk_sgmii.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c
> index 18de85709e87..6f4c1ca5a36f 100644
> --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c
> +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c
> @@ -32,12 +32,13 @@ static int mtk_pcs_setup_mode_an(struct mtk_pcs *mpcs)
> regmap_write(mpcs->regmap, SGMSYS_PCS_LINK_TIMER,
> SGMII_LINK_TIMER_DEFAULT);
>
> + /* disable remote fault & enable auto neg */
> regmap_read(mpcs->regmap, SGMSYS_SGMII_MODE, &val);
> - val |= SGMII_REMOTE_FAULT_DIS;
> + val |= SGMII_REMOTE_FAULT_DIS | SGMII_SPEED_DUPLEX_AN;
> regmap_write(mpcs->regmap, SGMSYS_SGMII_MODE, val);
>
> regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1, &val);
> - val |= SGMII_AN_RESTART;
> + val |= SGMII_AN_RESTART | SGMII_AN_ENABLE;

I'm not sure if I've asked this before, but why does SGMII_AN_RESTART
need to be set here? It could do with a comment in the code.

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

\
 
 \ /
  Last update: 2022-09-19 13:30    [W:0.060 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site