Messages in this thread | | | Date | Mon, 19 Sep 2022 10:05:24 +0200 | Subject | Re: [PATCH v2 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute() | From | AngeloGioacchino Del Regno <> |
| |
Il 16/09/22 15:38, Bo-Chen Chen ha scritto: > Warning: > ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ > expects argument of type ‘unsigned int’, but argument 4 has type ‘long > unsigned int’ [-Wformat=] > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../include/linux/dev_printk.h:129:27: note: in definition of macro ‘dev_printk’ > 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > | ^~~ > ../include/linux/dev_printk.h:163:31: note: in expansion of macro ‘dev_fmt’ > 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > | ^~~~~~~ > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:2: note: in expansion of > macro ‘dev_dbg’ > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ^~~~~~~ > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:36: note: format string is defined here > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ~^ > | | > | unsigned int > | %lx > > To fix this issue, we use %s to replace 0x%x. > > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Reported-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| |