Messages in this thread | | | Date | Wed, 14 Sep 2022 09:27:19 +0200 | From | Michael Walle <> | Subject | Re: [PATCH] mtd: spi-nor: gigadevice: gd25q256: replace gd25q256_default_init with gd25q256_post_bfpt |
| |
Am 2022-09-14 05:05, schrieb Yaliang Wang: > In case the mail list can't receive the email, I'd like to send the > email again. > > Sorry, I didn't make it clear. > I'm doing this because the flash info member parse_sfdp is initialized > to "true" by PARSE_SFDP macro, as you can see below > { "gd25q256", INFO(0xc84019, 0, 64 * 1024, 512) > PARSE_SFDP > FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | > SPI_NOR_TB_SR_BIT6) > FIXUP_FLAGS(SPI_NOR_4B_OPCODES) > .fixups = &gd25q256_fixups }, > > And when parse_sfdp is true, the function spi_nor_init_params() will > call spi_nor_parse_sfdp() to initialize the parameters, and I can't > see any other place to call the original default_init() hook in the > fixups other than in spi_nor_init_params_deprecated() -> > spi_nor_manufacturer_init_params(). > > After checking the history of why we are adding this, that is to say > the commit 48e4d973aefe ("mtd: spi-nor: Add a default_init() fixup > hook for gd25q256") and the corresponding disscusions, I believe it > was added for some reason, and we need to add back this function. > > On 9/13/22 18:46, Vanessa Page wrote: >> **[Please note: This e-mail is from an EXTERNAL e-mail address] >> >> Why are you doing this?
Vanessa Page is a bot/troll.
-michael
| |