Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 13 Sep 2022 10:41:09 -0700 | Subject | Re: [PATCH 00/11] perf test: test_intel_pt.sh: Add per-thread test |
| |
On Mon, Sep 12, 2022 at 1:34 AM Adrian Hunter <adrian.hunter@intel.com> wrote: > > Hi > > Here is a new per-thread test for the test_intel_pt.sh test script. > > The first 9 patches are tidy-ups for the script, mostly based on results > from the shellcheck utility. > > The 10th patch adds debug prints that the script will capture to help > verify correct operation. > > The final patch actually adds the new test. > > > Adrian Hunter (11): > perf test: test_intel_pt.sh: Add cleanup function > perf test: test_intel_pt.sh: Use a temp directory > perf test: test_intel_pt.sh: Fix redirection > perf test: test_intel_pt.sh: Stop using expr > perf test: test_intel_pt.sh: Stop using backticks > perf test: test_intel_pt.sh: Use grep -c instead of grep plus wc -l > perf test: test_intel_pt.sh: Use quotes around variable expansion > perf test: test_intel_pt.sh: Fix return checking > perf test: test_intel_pt.sh: Add more output in preparation for more tests > perf tools: Add debug messages and comments for testing > perf test: test_intel_pt.sh: Add per-thread test
I don't think I understood all the black magic in patch 11. :) At least we can move some helper functions to the lib and reuse them in other tests. I'll test that later..
So for patch 01-10,
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
> > tools/lib/perf/evlist.c | 2 + > tools/perf/builtin-record.c | 8 + > tools/perf/tests/shell/test_intel_pt.sh | 307 ++++++++++++++++++++++++++++++-- > tools/perf/util/evsel.c | 2 + > 4 files changed, 304 insertions(+), 15 deletions(-) > > > Regards > Adrian
| |