lkml.org 
[lkml]   [2022]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] PCI: Map PCI bios specific error to generic errno
Date
pci_read_config_byte() may return a PCI bios specific error value
(in my case PCIBIOS_DEVICE_NOT_FOUND 0x86) which is nonsensical
to return to the caller of of_irq_parse_pci() which expects
a negative errno if something goes wrong.

Use the appropriate mapping function before passing the error on.

Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/pci/of.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 196834ed44fe..130bcfe61e04 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -440,8 +440,10 @@ static int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *
* for PCI. If you do different, then don't use that routine.
*/
rc = pci_read_config_byte(pdev, PCI_INTERRUPT_PIN, &pin);
- if (rc != 0)
+ if (rc != 0) {
+ rc = pcibios_err_to_errno(rc);
goto err;
+ }
/* No pin, exit with no error message. */
if (pin == 0)
return -ENODEV;
--
2.36.0
\
 
 \ /
  Last update: 2022-09-01 17:25    [W:0.022 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site