Messages in this thread | | | Date | Thu, 1 Sep 2022 10:46:01 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v1 2/3] regmap: trace: Remove explicit castings |
| |
On Thu, 1 Sep 2022 17:18:01 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Sep 1, 2022 at 5:15 PM Mark Brown <broonie@kernel.org> wrote: > > On Thu, Sep 01, 2022 at 04:23:35PM +0300, Andy Shevchenko wrote: > > > There is no need to have explicit castings to the same type the > > > variables are of. Remove the explicit castings. > > > > IIRC this was an idiom that the trace code was using for some deep magic > > reason to do with some fiddly preprocessor stuff. > > Perhaps that (dark) magic disappeared a long time ago since in my > practice of adding trace events this is the first (and probably > oldest) one which has these castings. Perhaps Steven can shed a light. >
There was no dark magic for those castings. The trace events never needed them. It was added from the original commit:
fb2736bbaee0e ("regmap: Add basic tracepoints")
So, I'm all for dropping them.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
| |