lkml.org 
[lkml]   [2022]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops
    Date
    If the buffer pointer is NULL we already are in troubles since
    regmap bulk API expects caller to provide valid parameters,
    it dereferences that without any checks before we call for
    traces.

    Moreover, the current code will print garbage in the case of
    buffer is NULL and length is not 0.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/base/regmap/trace.h | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h
    index 04329ba68ec5..e92edc4f4ca5 100644
    --- a/drivers/base/regmap/trace.h
    +++ b/drivers/base/regmap/trace.h
    @@ -82,8 +82,7 @@ DECLARE_EVENT_CLASS(regmap_bulk,
    __assign_str(name, regmap_name(map));
    __entry->reg = reg;
    __entry->val_len = val_len;
    - if (val)
    - memcpy(__get_dynamic_array(buf), val, val_len);
    + memcpy(__get_dynamic_array(buf), val, val_len);
    ),

    TP_printk("%s reg=%x val=%s", __get_str(name),
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-09-01 15:25    [W:3.705 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site