Messages in this thread | | | From | <> | Subject | RE: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power management functions to pci1xxxx's quad-uart driver. | Date | Thu, 1 Sep 2022 13:49:26 +0000 |
| |
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Wednesday, August 31, 2022 1:26 AM > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jiri Slaby > <jirislaby@kernel.org>; Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>; Uwe > Kleine-König <u.kleine-koenig@pengutronix.de>; Johan Hovold > <johan@kernel.org>; Wander Lairson Costa <wander@redhat.com>; Eric > Tremblay <etremblay@distech-controls.com>; Maciej W. Rozycki > <macro@orcam.me.uk>; Geert Uytterhoeven <geert+renesas@glider.be>; > Jeremy Kerr <jk@ozlabs.org>; Phil Edworthy <phil.edworthy@renesas.com>; > Lukas Wunner <lukas@wunner.de>; Linux Kernel Mailing List <linux- > kernel@vger.kernel.org>; open list:SERIAL DRIVERS <linux- > serial@vger.kernel.org>; UNGLinuxDriver > <UNGLinuxDriver@microchip.com> > Subject: Re: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power > management functions to pci1xxxx's quad-uart driver. > > > On Tue, Aug 30, 2022 at 9:01 PM Kumaravel Thiagarajan > <kumaravel.thiagarajan@microchip.com> wrote: > > > > pci1xxxx's quad-uart function has the capability to wake up the host > > from suspend state. Enable wakeup before entering into suspend and > > disable wakeup upon resume. > > on resume Ok. I will modify this.
> > ... > > First of all, we have pm_ptr() and pm_sleep_ptr() with corresponding other > macros in pm.h. Use them. > Second, if you need to duplicate a lot of code from 8250_pci, split that code > to 8250_pcilib.c and use it in the driver. Ok. I will review and get back to you.
Thank You.
Regards, Kumaravel
| |