lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power management functions to pci1xxxx's quad-uart driver.
On Tue, Aug 30, 2022 at 9:01 PM Kumaravel Thiagarajan
<kumaravel.thiagarajan@microchip.com> wrote:
>
> pci1xxxx's quad-uart function has the capability to wake up the host from
> suspend state. Enable wakeup before entering into suspend and disable
> wakeup upon resume.

on resume

...

First of all, we have pm_ptr() and pm_sleep_ptr() with corresponding
other macros in pm.h. Use them.
Second, if you need to duplicate a lot of code from 8250_pci, split
that code to 8250_pcilib.c and use it in the driver.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-08-30 21:57    [W:0.156 / U:3.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site