Messages in this thread | | | Subject | Re: [PATCH v3 06/19] hwmon: (mr75203) fix multi-channel voltage reading | Date | Thu, 1 Sep 2022 16:12:34 +0300 | From | "Farber, Eliav" <> |
| |
On 8/31/2022 12:46 PM, Andy Shevchenko wrote: > On Tue, Aug 30, 2022 at 07:21:59PM +0000, Eliav Farber wrote: >> Fix voltage allocation and reading to support all channels in all VMs. >> Prior to this change allocation and reading were done only for the first >> channel in each VM. >> This change counts the total number of channels for allocation, and >> takes >> into account the channel offset when reading the sample data register. > > ... > >> struct pvt_device *pvt = dev_get_drvdata(dev); >> struct regmap *v_map = pvt->v_map; >> u32 n, stat; >> - u8 vm_idx; >> + u8 vm_idx, ch_idx; > > Can you keep it sorted by line length?
Fixed.
>> int ret; > > ... > >> const struct hwmon_channel_info **pvt_info; >> - u32 ts_num, vm_num, pd_num, val, index, i; >> + u32 ts_num, vm_num, pd_num, ch_num, val, index, i; > > Ditto. Fixed.
-- Thanks, Eliav
| |