lkml.org 
[lkml]   [2022]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 06/19] hwmon: (mr75203) fix multi-channel voltage reading
    On Tue, Aug 30, 2022 at 07:21:59PM +0000, Eliav Farber wrote:
    > Fix voltage allocation and reading to support all channels in all VMs.
    > Prior to this change allocation and reading were done only for the first
    > channel in each VM.
    > This change counts the total number of channels for allocation, and takes
    > into account the channel offset when reading the sample data register.

    ...

    > struct pvt_device *pvt = dev_get_drvdata(dev);
    > struct regmap *v_map = pvt->v_map;
    > u32 n, stat;
    > - u8 vm_idx;
    > + u8 vm_idx, ch_idx;

    Can you keep it sorted by line length?

    > int ret;

    ...

    > const struct hwmon_channel_info **pvt_info;
    > - u32 ts_num, vm_num, pd_num, val, index, i;
    > + u32 ts_num, vm_num, pd_num, ch_num, val, index, i;

    Ditto.

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2022-08-31 11:47    [W:4.066 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site