lkml.org 
[lkml]   [2022]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH v4 1/5] sysfs: Add attribute info for /sys/devices/.../coredump_disabled
From
This patch adds the specification for /sys/devices/.../coredump_disabled
attribute which allows the userspace to enable/disable devcoredump for a
particular device and drivers can use it to enable/disable functionality
accordingly. It is available when the CONFIG_DEV_COREDUMP is enabled and
driver has implemented the .coredump() callback.

Signed-off-by: Manish Mandlik <mmandlik@google.com>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
---
Hi Arend,

The existing /sys/class/devcoredump/disabled provides only a one-way
disable functionality for devcoredump. It also disables the devcoredump
for everyone who is using it.

This and the next patch provides a way to selectively enable/disable the
devcoredump by creating a /sys/devices/.../coredump_disabled sysfs entry.
The userspace can write 0/1 to it to enable/disable devcoredump for that
particular device and drivers can use it accordingly. It will only be
available along with the /sys/devices/.../coredump sysfs entry when the
CONFIG_DEV_COREDUMP is enabled and the driver has implemented the
.coredump() callback.

Please let me know what you think about this.

Thanks,
Manish.

Changes in v4:
- New patch in the series

Documentation/ABI/testing/sysfs-devices-coredump | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-devices-coredump b/Documentation/ABI/testing/sysfs-devices-coredump
index e459368533a4..4bcfc7dbad67 100644
--- a/Documentation/ABI/testing/sysfs-devices-coredump
+++ b/Documentation/ABI/testing/sysfs-devices-coredump
@@ -8,3 +8,17 @@ Description:
file will trigger the .coredump() callback.

Available when CONFIG_DEV_COREDUMP is enabled.
+
+What: /sys/devices/.../coredump_disabled
+Date: July 2022
+Contact: Manish Mandlik <mmandlik@google.com>
+Description:
+ The /sys/devices/.../coredump_disabled attribute can be used by
+ drivers to selectively enable/disable devcoredump functionality
+ for a device. The userspace can write 0/1 to it to control
+ enabling/disabling of devcoredump for that particular device.
+ This attribute is present only when the device is bound to a
+ driver which implements the .coredump() callback. The attribute
+ is readable and writeable.
+
+ Available when CONFIG_DEV_COREDUMP is enabled.
--
2.37.1.559.g78731f0fdb-goog
\
 
 \ /
  Last update: 2022-08-09 17:36    [W:0.046 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site