lkml.org 
[lkml]   [2022]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] thermal/of: Return -ENODEV instead of -EINVAL if registration fails
From
On 8/8/22 11:09, Daniel Lezcano wrote:
> The previous version of the OF code was returning -ENODEV if no
> thermal zones description was found or if the lookup of the sensor in
> the thermal zones was not found.
>
> The backend drivers are expecting this return value as an information
> about skipping the sensor initialization and considered as normal.
>
> Fix the return value by replacing -EINVAL by -ENODEV
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/thermal_of.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 368eb58e97cf..4210c18ef7b2 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -329,7 +329,7 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
> np = of_find_node_by_name(NULL, "thermal-zones");
> if (!np) {
> pr_err("Unable to find thermal zones description\n");

I really don't like that error message: People will see it (and complain)
whenever a sensor registers and there is no thermal zone, even though that
is perfectly normal (see description above).

Guenter

> - return ERR_PTR(-EINVAL);
> + return ERR_PTR(-ENODEV);
> }
>
> /*
> @@ -368,7 +368,7 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
> }
> }
> }
> - tz = ERR_PTR(-EINVAL);
> + tz = ERR_PTR(-ENODEV);
> out:
> of_node_put(np);
> return tz;

\
 
 \ /
  Last update: 2022-08-08 20:36    [W:0.220 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site