Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH RESEND] perf/core: Call LSM hook after copying perf_event_attr | Date | Mon, 8 Aug 2022 11:05:34 -0700 |
| |
It passes the attr struct to the security_perf_event_open() but it's not initialized yet.
Fixes: da97e18458fb ("perf_event: Add support for LSM and SELinux checks") Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- kernel/events/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 4d8c335a07db..6bf4e3078b29 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -12047,12 +12047,12 @@ SYSCALL_DEFINE5(perf_event_open, if (flags & ~PERF_FLAG_ALL) return -EINVAL; - /* Do we allow access to perf_event_open(2) ? */ - err = security_perf_event_open(&attr, PERF_SECURITY_OPEN); + err = perf_copy_attr(attr_uptr, &attr); if (err) return err; - err = perf_copy_attr(attr_uptr, &attr); + /* Do we allow access to perf_event_open(2) ? */ + err = security_perf_event_open(&attr, PERF_SECURITY_OPEN); if (err) return err; -- 2.37.1.559.g78731f0fdb-goog
| |