lkml.org 
[lkml]   [2022]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/28] mfd: intel_soc_pmic: Remove #ifdef guards for PM related functions


Le dim., août 7 2022 at 17:50:32 +0200, Andy Shevchenko
<andy.shevchenko@gmail.com> a écrit :
> On Sun, Aug 7, 2022 at 4:53 PM Paul Cercueil <paul@crapouillou.net>
> wrote:
>>
>> Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros
>> to handle the .suspend/.resume callbacks.
>>
>> These macros allow the suspend and resume functions to be
>> automatically
>> dropped by the compiler when CONFIG_SUSPEND is disabled, without
>> having
>> to use #ifdef guards.
>>
>> The advantage is then that these functions are now always compiled
>
> is that

I think that what I wrote is proper English.

>
>> independently of any Kconfig option, and thanks to that bugs and
>> regressions are easier to catch.
>
> ...
>
>> drivers/mfd/intel_soc_pmic_bxtwc.c | 7 +++----
>> drivers/mfd/intel_soc_pmic_core.c | 8 +++-----
>
> 1. These are two different drivers, the patch needs to be split.

Ok.

> 2. The Broxton Whiskey Cove should have a similar change. Which base
> have you used for your patch? Please, rebase on top of for-mfd-next.

That's based on v5.19.

> 3. The PMIC core actually is Crystal Cove driver and I have a pending
> series for that and I guess you know about it. Have you seen what have
> been done there?

No, I didn't know. I guess Lee can skip my patch 11/28 then.

Cheers,
-Paul


\
 
 \ /
  Last update: 2022-08-07 17:58    [W:0.072 / U:2.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site