Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 7 Aug 2022 17:50:32 +0200 | Subject | Re: [PATCH 11/28] mfd: intel_soc_pmic: Remove #ifdef guards for PM related functions |
| |
On Sun, Aug 7, 2022 at 4:53 PM Paul Cercueil <paul@crapouillou.net> wrote: > > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros > to handle the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without having > to use #ifdef guards. > > The advantage is then that these functions are now always compiled
is that
> independently of any Kconfig option, and thanks to that bugs and > regressions are easier to catch.
...
> drivers/mfd/intel_soc_pmic_bxtwc.c | 7 +++---- > drivers/mfd/intel_soc_pmic_core.c | 8 +++-----
1. These are two different drivers, the patch needs to be split. 2. The Broxton Whiskey Cove should have a similar change. Which base have you used for your patch? Please, rebase on top of for-mfd-next. 3. The PMIC core actually is Crystal Cove driver and I have a pending series for that and I guess you know about it. Have you seen what have been done there?
-- With Best Regards, Andy Shevchenko
| |