Messages in this thread | | | Date | Wed, 31 Aug 2022 13:15:51 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 13/14] ext2: replace bh_submit_read() helper with bh_read_locked() |
| |
On Wed 31-08-22 15:21:10, Zhang Yi wrote: > bh_submit_read() is almost the same as bh_read_locked(), switch to use > bh_read_locked() in read_block_bitmap(), prepare remove the old one. > > Signed-off-by: Zhang Yi <yi.zhang@huawei.com> ... > diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c > index c17ccc19b938..548a1d607f5a 100644 > --- a/fs/ext2/balloc.c > +++ b/fs/ext2/balloc.c > @@ -142,7 +142,7 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group) > if (likely(bh_uptodate_or_lock(bh))) > return bh; > > - if (bh_submit_read(bh) < 0) { > + if (bh_read_locked(bh, 0) < 0) {
I would just use bh_read() here and thus remove a bit more of the boilerplate code (like the bh_uptodate_or_lock() checking).
Honza
> brelse(bh); > ext2_error(sb, __func__, > "Cannot read block bitmap - " > -- > 2.31.1 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |