lkml.org 
[lkml]   [2022]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 0/3] net: sched: add other statistics when calling qdisc_drop()
On Sat, 27 Aug 2022 11:16:53 +0800 shaozhengchao wrote:
> On 2022/8/27 10:40, Jakub Kicinski wrote:
> > On Thu, 25 Aug 2022 11:29:40 +0800 Zhengchao Shao wrote:
> >> According to the description, "other" should be added when calling
> >> qdisc_drop() to discard packets.
> >
> > The fact that an old copy & pasted comment says something is not
> > in itself a sufficient justification to make code changes.
> >
> > qdisc_drop() already counts drops, duplicating the same information
> > in another place seems like a waste of CPU cycles.
>
> Hi Jakub:
> Thank you for your reply. It seems more appropriate to delete the other
> variable, if it is unused?

Yes, removing it SGTM.

\
 
 \ /
  Last update: 2022-08-30 06:49    [W:0.100 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site