Messages in this thread | | | Date | Fri, 26 Aug 2022 19:40:52 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 0/3] net: sched: add other statistics when calling qdisc_drop() |
| |
On Thu, 25 Aug 2022 11:29:40 +0800 Zhengchao Shao wrote: > According to the description, "other" should be added when calling > qdisc_drop() to discard packets.
The fact that an old copy & pasted comment says something is not in itself a sufficient justification to make code changes.
qdisc_drop() already counts drops, duplicating the same information in another place seems like a waste of CPU cycles.
| |