Messages in this thread Patch in this message | | | From | Li Zhong <> | Subject | [PATCH v1] drivers/base/auxiliary: check return value of strrchr() | Date | Sun, 28 Aug 2022 13:40:40 -0700 |
| |
From: lily <floridsleeves@gmail.com>
The return value of strrchr() could be NULL, which will cause invalid offset in (int)(p - name). So we check it here.
Signed-off-by: Li Zhong <floridsleeves@gmail.com> --- drivers/base/auxiliary.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c index 8c5e65930617..7ac23be47e1f 100644 --- a/drivers/base/auxiliary.c +++ b/drivers/base/auxiliary.c @@ -191,7 +191,8 @@ static int auxiliary_uevent(struct device *dev, struct kobj_uevent_env *env) name = dev_name(dev); p = strrchr(name, '.'); - + if (!p) + return -EINVAL; return add_uevent_var(env, "MODALIAS=%s%.*s", AUXILIARY_MODULE_PREFIX, (int)(p - name), name); } -- 2.25.1
| |