Messages in this thread | | | From | Prashant Malani <> | Date | Tue, 23 Aug 2022 10:50:58 -0700 | Subject | Re: [PATCH 4/4] platform/chrome: cros_ec_typec: Use Type-C driver data |
| |
Hi Tzung-Bi,
Thanks for reviewing the series.
On Mon, Aug 22, 2022 at 9:43 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > > index 7daf4207c11e..e3f75440030d 100644 > > --- a/drivers/platform/chrome/cros_ec_typec.c > > +++ b/drivers/platform/chrome/cros_ec_typec.c > > @@ -379,6 +379,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) > > ret = cros_typec_parse_port_props(cap, fwnode, dev); > > if (ret < 0) > > goto unregister_ports; > > + cap->driver_data = cros_port; > > Same as previous patch. I would suggest to send it in later series. For > example, I have no knowledge to judge if `cap` is a correct place to save > the driver data. > > For example, I'm wondering: is the `cap` "the Type-C port's driver"?
The Type-C framework uses [1] the cap->driver_data while creating the port device.
That said, sure, I can resend patch 3 and 4 when I upload the alt mode series.
[1] https://elixir.bootlin.com/linux/latest/source/drivers/usb/typec/class.c#L2098
| |