Messages in this thread Patch in this message | | | Date | Tue, 23 Aug 2022 04:43:54 +0000 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH 4/4] platform/chrome: cros_ec_typec: Use Type-C driver data |
| |
On Fri, Aug 19, 2022 at 07:08:05PM +0000, Prashant Malani wrote: > Altmode driver callbacks need EC-specific port information to > communicate with the ChromeOS EC. To accomplish this, save a > pointer to the driver-specific port struct in the Type-C port's > driver data field. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> > --- > drivers/platform/chrome/cros_ec_typec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 7daf4207c11e..e3f75440030d 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -379,6 +379,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) > ret = cros_typec_parse_port_props(cap, fwnode, dev); > if (ret < 0) > goto unregister_ports; > + cap->driver_data = cros_port;
Same as previous patch. I would suggest to send it in later series. For example, I have no knowledge to judge if `cap` is a correct place to save the driver data.
For example, I'm wondering: is the `cap` "the Type-C port's driver"?
| |