lkml.org 
[lkml]   [2022]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 2/2] net: phy: tja11xx: add interface mode and RMII REF_CLK support
> +/* Configure REF_CLK as input in RMII mode */
> +#define TJA110X_RMII_MODE_REFCLK_IN BIT(0)
> +
> struct tja11xx_priv {
> char *hwmon_name;
> struct device *hwmon_dev;
> struct phy_device *phydev;
> struct work_struct phy_register_work;
> + u32 quirks;

A quirk is generally a workaround for a bug. Configuring a clock is
not a quirk. I would rename this flags.

Andrew

\
 
 \ /
  Last update: 2022-08-19 14:51    [W:0.811 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site