Messages in this thread | | | Date | Fri, 19 Aug 2022 14:50:31 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next 2/2] net: phy: tja11xx: add interface mode and RMII REF_CLK support |
| |
> +/* Configure REF_CLK as input in RMII mode */ > +#define TJA110X_RMII_MODE_REFCLK_IN BIT(0) > + > struct tja11xx_priv { > char *hwmon_name; > struct device *hwmon_dev; > struct phy_device *phydev; > struct work_struct phy_register_work; > + u32 quirks;
A quirk is generally a workaround for a bug. Configuring a clock is not a quirk. I would rename this flags.
Andrew
| |