Messages in this thread | | | From | Wei Fang <> | Subject | RE: [PATCH net-next 2/2] net: phy: tja11xx: add interface mode and RMII REF_CLK support | Date | Mon, 22 Aug 2022 01:16:07 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: 2022年8月19日 20:51 > To: Wei Fang <wei.fang@nxp.com> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > f.fainelli@gmail.com; hkallweit1@gmail.com; linux@armlinux.org.uk; > netdev@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 2/2] net: phy: tja11xx: add interface mode and > RMII REF_CLK support > > > +/* Configure REF_CLK as input in RMII mode */ > > +#define TJA110X_RMII_MODE_REFCLK_IN BIT(0) > > + > > struct tja11xx_priv { > > char *hwmon_name; > > struct device *hwmon_dev; > > struct phy_device *phydev; > > struct work_struct phy_register_work; > > + u32 quirks; > > A quirk is generally a workaround for a bug. Configuring a clock is not a quirk. I > would rename this flags. > Thanks, I'll rename it.
| |