Messages in this thread Patch in this message | | | From | Tuo Cao <> | Subject | [PATCH] sched: core: remove access_ok() before copy_to_user() | Date | Mon, 15 Aug 2022 22:21:37 +0800 |
| |
If usize > ksize, usize may be not valid and if(!access_ok()) will return -EFAULT. But ksize may be valid, copy_to_user() should be executed.And also, copy_to_user() will calls access_ok() to test whether a block of memory is a valid user space address.
Signed-off-by: Tuo Cao <91tuocao@gmail.com> --- kernel/sched/core.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ee28253c9ac0..fe6a65a54626 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7975,9 +7975,6 @@ sched_attr_copy_to_user(struct sched_attr __user *uattr, { unsigned int ksize = sizeof(*kattr); - if (!access_ok(uattr, usize)) - return -EFAULT; - /* * sched_getattr() ABI forwards and backwards compatibility: * -- 2.17.1
| |