lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mtd: rawnand: denali: Fix a possible resource leak in denali_pci_probe
Date
Call pci_release_regions() to retrieve the allocated resource when
devm_ioremap() or denali_init() failed.

Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
---
drivers/mtd/nand/raw/denali_pci.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c
index de7e722d3826..40943cda0914 100644
--- a/drivers/mtd/nand/raw/denali_pci.c
+++ b/drivers/mtd/nand/raw/denali_pci.c
@@ -74,21 +74,22 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
return ret;
}

+ ret = -ENOMEM;
denali->reg = devm_ioremap(denali->dev, csr_base, csr_len);
if (!denali->reg) {
dev_err(&dev->dev, "Spectra: Unable to remap memory region\n");
- return -ENOMEM;
+ goto out_release_pci;
}

denali->host = devm_ioremap(denali->dev, mem_base, mem_len);
if (!denali->host) {
dev_err(&dev->dev, "Spectra: ioremap failed!");
- return -ENOMEM;
+ goto out_release_pci;
}

ret = denali_init(denali);
if (ret)
- return ret;
+ goto out_release_pci;

nsels = denali->nbanks;

@@ -116,6 +117,8 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)

out_remove_denali:
denali_remove(denali);
+out_release_pci:
+ pci_release_regions(dev);
return ret;
}

--
2.25.1
\
 
 \ /
  Last update: 2022-08-01 10:03    [W:0.473 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site