Messages in this thread Patch in this message | | | From | Sherry Yang <> | Subject | [PATCH v1] xfs: initialize error in xfs_defer_finish_one | Date | Mon, 1 Aug 2022 12:03:11 -0700 |
| |
Path through non-void function 'xfs_defer_finish_one' may return error uninitialized if no iteration of 'list_for_each_safe' occurs. Fix this by initializing error.
Fixes: bb47d79750f1 ("xfs: refactor xfs_defer_finish_noroll") Cc: stable@vger.kernel.org Signed-off-by: Sherry Yang <sherry.yang@oracle.com> --- fs/xfs/libxfs/xfs_defer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c index 5a321b783398..3188712ff34e 100644 --- a/fs/xfs/libxfs/xfs_defer.c +++ b/fs/xfs/libxfs/xfs_defer.c @@ -468,7 +468,7 @@ xfs_defer_finish_one( const struct xfs_defer_op_type *ops = defer_op_types[dfp->dfp_type]; struct xfs_btree_cur *state = NULL; struct list_head *li, *n; - int error; + int error = 0; trace_xfs_defer_pending_finish(tp->t_mountp, dfp); -- 2.31.1
| |