Messages in this thread |  | | Date | Thu, 7 Jul 2022 13:38:51 +0200 | From | Marco Felsch <> | Subject | Re: [PATCH V3 6/7] arm64: dts: imx8mp: add interconnects for media blk ctrl |
| |
Hi,
thanks for your patch and the work on this.
On 22-07-03, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add interconnect property for media blk ctrl > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 13a2ee77d3c6..08bd57742294 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
Can you please add:
#include <dt-bindings/interconnect/fsl,imx8mp.h>
else this won't compile.
Regards, Marco
> @@ -1066,6 +1066,18 @@ media_blk_ctrl: blk-ctrl@32ec0000 { > "lcdif1", "isi", "mipi-csi2", > "lcdif2", "isp", "dwe", > "mipi-dsi2"; > + interconnects = > + <&noc IMX8MP_ICM_LCDIF_RD &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_LCDIF_WR &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_ISI0 &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_ISI1 &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_ISI2 &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_ISP0 &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_ISP1 &noc IMX8MP_ICN_MEDIA>, > + <&noc IMX8MP_ICM_DWE &noc IMX8MP_ICN_MEDIA>; > + interconnect-names = "lcdif-rd", "lcdif-wr", "isi0", > + "isi1", "isi2", "isp0", "isp1", > + "dwe"; > clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>, > <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>, > -- > 2.25.1 > > >
|  |