Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Wed, 6 Jul 2022 14:11:42 +0200 | Subject | Re: [PATCH] gpio: pxa: schedule a devm action for the clock struct |
| |
On Wed, Jul 6, 2022 at 1:49 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: s> > On Tue, Jul 5, 2022 at 7:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > The clock is never released after probe(). Schedule devm actions for > > putting and disabling the clock. > > ... > > > Reported-by: Signed-off-by: Yuan Can <yuancan@huawei.com> > > Me puzzled. >
Yuan Can sent the following patch: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220704130323.104294-1-yuancan@huawei.com/
I responded that it was not complete and sent this instead.
> > ... > > > + ret = devm_add_action_or_reset(&pdev->dev, pxa_gpio_clk_put, clk); > > + if (ret) > > + return ret; > > + > > ret = clk_prepare_enable(clk); > > + if (ret) > > + return ret; > > + > > + ret = devm_add_action_or_reset(&pdev->dev, > > + pxa_gpio_clk_disable_unprepare, clk); > > + if (ret) > > return ret; > > Can we use recently introduced clk APIs for that? Maybe Stephen has an > immutable branch you may reuse?
Sure, sounds good! Stephen, would you mind providing me with a branch for that?
Bart
> > -- > With Best Regards, > Andy Shevchenko
| |