Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 6 Jul 2022 13:48:26 +0200 | Subject | Re: [PATCH] gpio: pxa: schedule a devm action for the clock struct |
| |
On Tue, Jul 5, 2022 at 7:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > The clock is never released after probe(). Schedule devm actions for > putting and disabling the clock.
...
> Reported-by: Signed-off-by: Yuan Can <yuancan@huawei.com>
Me puzzled.
...
> + ret = devm_add_action_or_reset(&pdev->dev, pxa_gpio_clk_put, clk); > + if (ret) > + return ret; > + > ret = clk_prepare_enable(clk); > + if (ret) > + return ret; > + > + ret = devm_add_action_or_reset(&pdev->dev, > + pxa_gpio_clk_disable_unprepare, clk); > + if (ret) > return ret;
Can we use recently introduced clk APIs for that? Maybe Stephen has an immutable branch you may reuse?
-- With Best Regards, Andy Shevchenko
| |