Messages in this thread | | | Date | Tue, 5 Jul 2022 09:21:49 +0200 | Subject | Re: [PATCH] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Hold reference returned by of_get_parent() | From | Neil Armstrong <> |
| |
+ linux-amlogic, linux-arm-kernel, linux-kernel
On 05/07/2022 04:15, Liang He wrote: > We should hold the reference returned by of_get_parent() and use it > to call of_node_put() for reference balance. > > Fixes: 8eff8b4e22d9 ("phy: amlogic: phy-meson-axg-mipi-pcie-analog: add support for MIPI DSI analog") > Signed-off-by: Liang He <windhl@126.com> > --- > drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c > index 1027ece6ca12..a3e1108b736d 100644 > --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c > +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c > @@ -197,7 +197,7 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev) > struct phy_provider *phy; > struct device *dev = &pdev->dev; > struct phy_axg_mipi_pcie_analog_priv *priv; > - struct device_node *np = dev->of_node; > + struct device_node *np = dev->of_node, *parent_np; > struct regmap *map; > int ret; > > @@ -206,7 +206,9 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev) > return -ENOMEM; > > /* Get the hhi system controller node */ > - map = syscon_node_to_regmap(of_get_parent(dev->of_node)); > + parent_np = of_get_parent(dev->of_node); > + map = syscon_node_to_regmap(parent_np); > + of_node_put(parent_np); > if (IS_ERR(map)) { > dev_err(dev, > "failed to get HHI regmap\n");
| |