Messages in this thread | | | Date | Sat, 30 Jul 2022 23:42:05 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support |
| |
Hi!
> From: Alice Chen <alice_chen@richtek.com> > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > The Flash LED in MT6370 has 2 channels and support torch/strobe mode. > Add the support of MT6370 FLASH LED. > > Signed-off-by: Alice Chen <alice_chen@richtek.com>
> +config LEDS_MT6370_FLASHLIGHT > + tristate "Flash LED Support for MediaTek MT6370 PMIC" > + depends on LEDS_CLASS
I'd name it just LEDS_MT6370_FLASH.
> +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2022 Richtek Technology Corp. > + * > + * Author: Alice Chen <alice_chen@richtek.com
Add ">" at end of line.
The series is quite big, would it be possible to submit LED changes in separate series?
Thanks, Pavel
-- People of Russia, stop Putin before his war on Ukraine escalates. [unhandled content-type:application/pgp-signature] | |