Messages in this thread | | | Date | Fri, 22 Jul 2022 12:52:09 +0200 | Subject | Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support | From | AngeloGioacchino Del Regno <> |
| |
Il 22/07/22 12:24, ChiaEn Wu ha scritto: > From: ChiYuan Huang <cy_huang@richtek.com> > > The MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery > charger, a USB Type-C & Power Delivery (PD) controller, dual > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > In MediaTek MT6370, there are four channel current-sink RGB LEDs that > support hardware pattern for constant current, PWM, and breath mode. > Isink4 channel can also be used as a CHG_VIN power good indicator. > > Signed-off-by: Alice Chen <alice_chen@richtek.com> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> --- > > v6 > - Remove the 'ko' from mt6370 led Kconfig description. > - Add both authors for Alice and ChiYuan. > - Use pdata to distinguish the code from mt6370/71 to mt6372. > - Instead of 'state' define, use the 'state' enum. > - Fix the typo for 'MT6372_PMW_DUTY'. > - For pwm_duty define, replace with bit macro - 1. > - Refine all the labels from 'out' to 'out_unlock'. > - Use struct 'dev' variable and 'dev_err_probe' to optimize the LOC. > - Revise for the array initialization from {0} to {}. > - Move into rgb folder and rename file name to 'leds-mt6370-rgb'. > - Refine the 'comma' usage in struct/enum. > --- > drivers/leds/rgb/Kconfig | 13 + > drivers/leds/rgb/Makefile | 1 + > drivers/leds/rgb/leds-mt6370-rgb.c | 1004 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 1018 insertions(+) > create mode 100644 drivers/leds/rgb/leds-mt6370-rgb.c >
| |