Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 3 Jul 2022 20:36:20 +0200 | Subject | Re: [PATCH v2 5/9] dt_bindings: rs485: Correct delay values |
| |
On Sun, Jul 3, 2022 at 7:02 PM Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote: > > From: Lino Sanfilippo <l.sanfilippo@kunbus.com> > > Currently the documentation claims that a maximum of 1000 msecs is allowed > for RTS delays. However nothing actually checks the values read from device > tree/ACPI and so it is possible to set much higher values. > > There is already a maximum of 100 ms enforced for RTS delays that are set > via the uart TIOCSRS485 ioctl. To be consistent with that use the same > limit for DT/ACPI values. > > Although this change is visible to userspace the risk of breaking anything > when reducing the max delays from 1000 to 100 ms should be very low, since > 100 ms is already a very high maximum for delays that are usually rather in > the usecs range.
Yeah, something similar is what you need to add to the previous patch IIUC.
-- With Best Regards, Andy Shevchenko
| |