Messages in this thread |  | | From | Cornelia Huck <> | Subject | Re: [PATCH v5 1/5] vfio: Add the device features for the low power entry and exit | Date | Tue, 26 Jul 2022 15:13:07 +0200 |
| |
On Tue, Jul 26 2022, Abhishek Sahu <abhsahu@nvidia.com> wrote:
> #define VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP 4 > > /* > * Upon VFIO_DEVICE_FEATURE_SET, disallow use of device low power states as > * previously enabled via VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY or > * VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP device features. > * This device feature IOCTL may itself generate a wakeup eventfd notification > * in the latter case if the device has previously entered a low power state.
Nit: s/has/had/
> */ > #define VFIO_DEVICE_FEATURE_LOW_POWER_EXIT 5
I haven't followed this closely, and I'm not that familiar with power management, but at least I can't spot anything obviously problematic.
|  |